Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Comment Javascript Object #25

Closed
jkeesh opened this issue Dec 21, 2010 · 2 comments
Closed

Create Comment Javascript Object #25

jkeesh opened this issue Dec 21, 2010 · 2 comments

Comments

@jkeesh
Copy link
Owner

jkeesh commented Dec 21, 2010

We definitely want a Comment javascript object in terms of managing the code. We also probably want a Shortcut object. The CodeFile object should have a list of Comment objects. A CodeFile can have an isEditable parameter which tells the comments whether they are editable.

The javascript code probably needs some decompositions. any thoughts?

UPDATE:
I've been working on copying the comment related functions in codefile to functions in comment because it makes more sense. no tests yet there, and it does not yet use any of hte comment stuff, but we should transition to it.

@econner
Copy link
Collaborator

econner commented Dec 22, 2010

Ok I just spent a ton of time on this, got confused and screwed a bunch of stuff up but didn't commit anything so that's good at least. I'm gonna take a break and then start over.. there are a lot of confusing dependencies in there.

@jkeesh
Copy link
Owner Author

jkeesh commented Dec 23, 2010

it seems to work completely, but there are a few instances where it messed up the keyboard shortcuts. that shouldnt be too hard to fix, cause the way you split it up is way better.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants