Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable release of 0.5.0? #16

Closed
ericswpark opened this issue Jun 18, 2021 · 6 comments
Closed

Stable release of 0.5.0? #16

ericswpark opened this issue Jun 18, 2021 · 6 comments

Comments

@ericswpark
Copy link
Contributor

Hi, when would the code in the ci-test branch be merged into master? No rush, but it's been nearly a month and I was wondering if the code would make it to a stable release. Thanks!

@jkeifer
Copy link
Owner

jkeifer commented Jun 18, 2021

It will, I promise. The ci-test branch is still full of half-baked CI ideas that I need to get back to and clean up before it can be merged. Things have gotten pretty busy for me, but I expect to have enough time to get that done by the end of July, if not sooner. I hope that timeline is okay.

@ericswpark
Copy link
Contributor Author

Ah, cool, thank you for the reply! Again, no pressure; just wanted to make sure the repo wasn't forgotten or anything.

@jkeifer
Copy link
Owner

jkeifer commented Jul 26, 2021

@ericswpark I just pushed out a stable release of 0.5.0. It has a lot of changes in it, but it now has lots of tests, so I'm hoping you shouldn't notice any problems with all the refactoring and cleanup. If you do have any problems please let me know.

@jkeifer jkeifer closed this as completed Jul 26, 2021
@ericswpark
Copy link
Contributor Author

@jkeifer thank you so much! I'm integrating the changes in 0.5.0 into my project right now. I noticed the on_completion() code you proposed in #18 didn't make it in yet. Do you want me to make a PR for it or would you prefer to retain authorship and commit yourself?

Again, thank you for the release!

@jkeifer
Copy link
Owner

jkeifer commented Jul 26, 2021

You're welcome!

I just double checked and I see that change in there, in views.py on lines 103 - 114 and 263. Are you having a problem with that new behavior not working?

@ericswpark
Copy link
Contributor Author

I have no idea how I missed the new code in there. Sorry about that :o I'll add it to my project and see if it works. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants