Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit found that the transferFrom function never deducts the allowance value #137

Open
michael7245 opened this issue Feb 9, 2022 · 1 comment

Comments

@michael7245
Copy link

function transferFrom(address from, address to, uint value) public returns(bool) {

Hello,

We used this code for our BEP-20 token project as none of us really had any smart contract experience. Our project ended up getting a lot of traction and so we took the next step and got an audit from Certik. They raised a critical error with the TransferFrom function because the allowance value never gets deducted.

Obviously we don't blame you because this contract was used for learning purposes but I wanted to let you know just in case you had thought about this before and felt there was another way this error was accounted for. Thanks!

@michael7245
Copy link
Author

@jklepatch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant