Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniswap Token.fetchData is not a function #99

Open
wcDogg opened this issue Jul 15, 2021 · 7 comments
Open

Uniswap Token.fetchData is not a function #99

wcDogg opened this issue Jul 15, 2021 · 7 comments

Comments

@wcDogg
Copy link

wcDogg commented Jul 15, 2021

This issue is for 'Profitable Flashloans' but it looks like it applies to other courses. I'm a tech writer with reasonable Python skills + a bit of JS and yet I have no friggin' clue what to do next. Anyone considering Eattheblocks courses should also be interested in this thread - How's the support? How explicit are course instructions? How well are the courses maintained?

Following the course instructions + the Uniswap V2 instructions, I installed npm install @uniswap/sdk.

The course uses fetchData which appears to be Uniswap V1.

Saw #53 and verified that some form of fetchTokenData and fetchPairData is for Uniswap V2

I thought I was using V2. When I couldn't get Fetcher to work, looked at package.json and see I have @uniswap/sdk ^3.0.3

I imagine this means I have Uniswap V3 which is weird because the install commands are totally different. Here's the V3 instructions:

Adding to my saga, I don't understand the V3 documentation at all - I see nothing about Fetch, and all of it looks very different from V2.

I need detailed, explicit instructions on what to do here, otherwise the course in unusable for me.

And clearly the courses need updating - the V1 instructions are completely outdated and the V2 - V3 straddle needs to be addressed.

@TimothyHyland
Copy link
Contributor

a simple npm install in main directory of code will install all needed dependencies. You installed the newer version of Uniswap sdk which uses different code. Are you a student at Eattheblocks ? If you were you would have private discord and forum to ask questions in for faster response than this.

@YakovKontarook
Copy link

Hey did you solve this problem?

@wcDogg
Copy link
Author

wcDogg commented Aug 27, 2021

@Woodcreek - Apologies for delay - offline for a bit.

@TimothyHyland -

Of course I'm a student - how else could I ask about specific course instructions?. No, I can't access the Discord. Maybe Discord doesn't like Brave browser? Don't know, don't care.

Even if I could access a private forum, I'd still be posting here. These are the public repos used in your courses. I came here to review my code (useless), so it's here I posted.

Eat the Blocks courses are expensive with few user reviews. And like it or not, you'll get questions here. How you answer says a lot

You could have said, "We're updating the videos, in the meantime, here's the Uniswap V3 repo link". That's the only acceptable reply here or on Discord.

Refund requested.

A final word about Teachable - they are not like Udemy or Lynda who handle billing and refunds. With Teachable you have to contact the 'school owner'.

@TimothyHyland
Copy link
Contributor

@wcDogg

Great! Being a student at Eattheblocks, you would have received an onboarding email with all support links. Your preference of support venue is always your choice. I merely mentioned that Discord seems to be the faster turn around for answers.

@Nkanyiso04
Copy link

Nkanyiso04 commented Sep 2, 2021 via email

@felixsc1
Copy link

felixsc1 commented Mar 25, 2022

I bought the course in 2022. Guess it was a mistake.. uniswap V1 is totally outdated, I'll try to get it to work with V3 instead. @wcDogg did you finally solve it?

@aagbotemi
Copy link

Hi, @felixsc1, have you been able to solve this issue, I'm facing the same error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants