Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency on retiring spatial infrastructure packages #45

Closed
rsbivand opened this issue Apr 13, 2023 · 5 comments
Closed

dependency on retiring spatial infrastructure packages #45

rsbivand opened this issue Apr 13, 2023 · 5 comments

Comments

@rsbivand
Copy link

You will be aware, for example from:
https://r-spatial.org/r/2022/04/12/evolution.html,
https://r-spatial.org/r/2022/12/14/evolution2.html,
https://r-spatial.org/r/2023/04/10/evolution3.html and
https://rsbivand.github.io/csds_jan23/bivand_csds_ssg_230117.pdf and
perhaps view https://www.youtube.com/watch?v=TlpjIqTPMCA&list=PLzREt6r1NenmWEidssmLm-VO_YmAh4pq9&index=1
that rgdal, rgeos and maptools will be retired this
year, in October 2023.

eeptools uses maptools::spCbind, which could be replaced by sp::cbind. The use is however noted as deprecated in your code, so simply removing mapmerge etc. might be simplest.

Try running CMD check under a scenario using sp evolution status 2 (substitute use of rgdal with sf for projection/transformation/CRS) and absence of retiring packages from the library path.

@rsbivand
Copy link
Author

It also looks as though you use:

  Missing link or links in documentation object ‘ggmapmerge.Rd’:
    ‘gpclibPermit’

Please test with maptools 1.1-7 at https://r-forge.r-project.org/R/?group_id=943 is being submitted, and your package refers to elide which has moved to sp (HEAD of edzer/sp@main).

@rsbivand
Copy link
Author

You need to act now: https://cran.r-project.org/web/checks/check_results_eeptools.html The warnings will spread to all flavours shortly. The functions in R/mapfunctions.R are all marked deprecated, so simply remove them and all mention of maptools. If you still need the sp object in the example, serialise it as data rather than reading from file.

@jknowles
Copy link
Owner

Thanks - I will address this with deprecation - I appreciate the thorough instructions so this change was quick to implement.

@rsbivand
Copy link
Author

rsbivand commented Jun 1, 2023

Both maptools 1.1-7 and sp 1.6-1 are on CRAN, so warnings are appearing: https://cran.r-project.org/web/checks/check_results_eeptools.html.

@jknowles
Copy link
Owner

jknowles commented Jun 1, 2023

Closed by 8f7905b

@jknowles jknowles closed this as completed Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants