Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange error on Travis CI #23

Closed
yoyurec opened this issue Jan 7, 2015 · 12 comments
Closed

Strange error on Travis CI #23

yoyurec opened this issue Jan 7, 2015 · 12 comments
Assignees
Labels

Comments

@yoyurec
Copy link

yoyurec commented Jan 7, 2015

Locally all is Ok, but when i run it on TravisCI i got errors.
Do 'grunt-iconizr' has some system software requirements?

>npn install --loglevel info:

...
npm info postinstall svg-sprite@0.3.2
npm ERR! cb() never called!
npm ERR! not ok code 0
...
@yoyurec yoyurec changed the title Strange error Strange error on Travis CI Jan 7, 2015
@jkphl jkphl added the question label Jan 7, 2015
@jkphl jkphl self-assigned this Jan 7, 2015
@yoyurec
Copy link
Author

yoyurec commented Jan 7, 2015

looking to svg-sprite@0.3.2 i hope it won't reproduce with 1.x version...
when is next grunt-iconizr release? 😳

@jkphl
Copy link
Owner

jkphl commented Jan 7, 2015

Hi @yoyurec,

not that I'd know. Sorry, I don't think I can help you here, as the error message is not really helpful. Unfortunately, I did never run the "old" versions of node-iconizr or svg-sprite on Travis. The new version of svg-sprite passes just fine, though. Please understand that -- as I'm currently working on a complete rewrite of node-iconizr (and subsequently grunt-iconizr) -- I won't put any effort into the old versions anymore.

Cheers,
Joschi

@jkphl
Copy link
Owner

jkphl commented Jan 7, 2015

:D our messages just crossed ... We'll, if there don't arise any problems, I'd guess within the next two weeks, depending on whether I'll immediately add support for inline SVG or not (and do that shortly after the release). I'm not really decided on that right now, still figuring out the most reasonable approach.

@yoyurec
Copy link
Author

yoyurec commented Jan 7, 2015

within the next two weeks

I was hoping in 2h )))
sitting here and refreshing repo page

is possible to do legacy release of grunt-iconizr with new svg-sprite in dependency, but without new features support?

@jkphl
Copy link
Owner

jkphl commented Jan 7, 2015

Unfortunately that's impossible. svg-sprite has been rewritten from scratch and the API changed completely, there's no way the two would work together. Sorry, but you'll have to wait for the new generation. I'll keep you posted! ;)

@yoyurec
Copy link
Author

yoyurec commented Jan 7, 2015

👍

@yoyurec
Copy link
Author

yoyurec commented Jan 7, 2015

it's NPM, needed 2.x version! (Travis CI uses 1.x by default)
https://stackoverflow.com/questions/26474640/why-travisci-builds-fails-during-npm-install-due-to-file-lock

...
before_script:
  - npm install -g npm@2
...

maybe you should add it to readme file...

@jkphl
Copy link
Owner

jkphl commented Jan 7, 2015

Ah, good to know, thanks for the heads-up. Will add it to the README tomorrow! 👍

@jkphl
Copy link
Owner

jkphl commented Jan 7, 2015

In fact, when I have a look at the .travis.yml of the latest svg-sprite:

...
before_install:
  - npm update -g npm
...

On the other hand, I'm not sure if this is really something that should be part of grunt-iconizr's README. In fact, it's svg-sprite that has this requirement, and there are probably way more modules out there requiring NPM 2. I've never seen a hint specifically for Travis users in a module's READMEs, and somehow I get the impression that this is a rather generic topic which could also be seen as base knowledge for devs using Travis CI, don't you think?

@jkphl jkphl closed this as completed Jan 7, 2015
@yoyurec
Copy link
Author

yoyurec commented Jan 8, 2015

In fact, when I have a look at the .travis.yml of the latest svg-sprite

yes, but i'm not testing svg-sprite, i'm testing my private repo with grunt-iconizr (which uses svg-sprite) in dependencies...
so i should to be noticed in readme to use in my .travis.yml config latest NPM to get grunt-iconizr works properly.

..on other hand, you are right - it's a dev knowledge and experience: "use latest NPM on local machine & 'Travis CI' in own projects to be sure that all is OK"

@yoyurec
Copy link
Author

yoyurec commented Jan 8, 2015

Another reason to add info - you already doing it:

This plugin requires Grunt ~0.4.2

@jkphl
Copy link
Owner

jkphl commented Jan 8, 2015

use latest NPM on local machine & 'Travis CI' in own projects to be sure that all is OK

Sounds reasonable and ist not too much to clutter the README. Will do that!

This plugin requires Grunt ~0.4.2

... standard text inserted by grunt-init gruntplugin, nothing I did write on my own. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants