Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create TrainingPhase class and/or add "add_training_phase" method to ParametricDR #1

Closed
einbandi opened this issue Jul 5, 2022 · 1 comment

Comments

@einbandi
Copy link
Collaborator

einbandi commented Jul 5, 2022

This class/method should allow users to set all the parameters required for a training phase. These are:

  • number of epochs
  • sampling method
  • batch-wise relations (specified as a dict, so custom loss functions can acces them)
  • loss function (which gets passed everything [model, global relations, batch-wise relations, batch] and accesses parts through keys)
@einbandi einbandi self-assigned this Jul 5, 2022
@einbandi
Copy link
Collaborator Author

einbandi commented Jul 5, 2022

There are three possibilities for the API:

  1. specify phases at training time: dr.train(phases=<list of TrainingPhase objects>)
  2. specify phases in __init__: `dr = ParametricDR(..., training_phases=)
  3. add phases one by one before training dr.add_training_phase(**kwargs)

Choose one or allow multiple?

@einbandi einbandi moved this from To do to In progress in Implement base functionality Jul 7, 2022
@einbandi einbandi moved this from In progress to Done in Implement base functionality Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

1 participant