Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add_training_phase does not accept TrainingPhase object as input #10

Closed
einbandi opened this issue Jul 8, 2022 · 0 comments
Closed

add_training_phase does not accept TrainingPhase object as input #10

einbandi opened this issue Jul 8, 2022 · 0 comments
Projects
Implement base functionality

Comments

@einbandi
Copy link
Collaborator

einbandi commented Jul 8, 2022 •
edited

So far, add_training_phase only accepts kwargs with the settings. Rewrite, so that it also accepts a full TrainingPhase object as the first (optional) parameter. This requires some checks and should probably be done in conjunction with the additional functionality to set default values (see Issue #11).
@einbandi einbandi changed the title _add_training_phase does not allow TrainingPhase object add_training_phase does not accept TrainingPhase object as input Jul 8, 2022
@einbandi einbandi moved this from To do to In progress in Implement base functionality Jul 8, 2022
@einbandi einbandi moved this from In progress to Done in Implement base functionality Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
Implement base functionality
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@einbandi