Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement memory-efficient subsampling of non-square or non-sparse relation data #13

Closed
einbandi opened this issue Jul 11, 2022 · 0 comments

Comments

@einbandi
Copy link
Collaborator

einbandi commented Jul 11, 2022

So far, subsampling is only properly implemented for dense, square tensors and arrays. Other RelationData subclasses internally are converted to dense representations for subsampling. This is memory-inefficient. For the triangular representations, the index lists must be converted accordingly to enable a direct indexing without having to call to_square...(). For the sparse matrix representation it should be enough to check that subsampling works properly with a similar implementation as for the dense case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

1 participant