Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tapes: When next part is changed manually #22

Closed
Tsillen opened this issue Oct 30, 2015 · 3 comments
Closed

Tapes: When next part is changed manually #22

Tsillen opened this issue Oct 30, 2015 · 3 comments

Comments

@Tsillen
Copy link

Tsillen commented Oct 30, 2015

Tapes: When next part is changed manually changed back to one or whatever the next part x,y is not automatically changed.

I.e. I changed it to part 1 , it thinks next part is at part 17

@mrandt
Copy link
Contributor

mrandt commented Nov 18, 2015

Bug still exists in version 17_11_2015.

If I manually change the number in "Next" column (Tape Positions List), Next X and Next Y should be updated.

Also, when executing "Set Hole 1" I would assume that Next X and Next Y should be updated.

@mrandt
Copy link
Contributor

mrandt commented Nov 30, 2015

Copy & pasted related issue from: http://liteplacer.com/phpBB/viewtopic.php?f=10&t=208#p1478

If you:

  1. Move to first component's hole
  2. Add component
  3. Set component hole
    is works fine.

BUT, if you:

  1. Click Add component
  2. Move to first component's hole
  3. Set component's hole
    then program (wrong) takes "Next" position from the last hole added (previous component) and when you set component's hole, "next" position isn't turned into component's hole, but stays the same.

@mrandt
Copy link
Contributor

mrandt commented Dec 1, 2015

I have fixed these issues in code and created a pull request for my changes:
#37

Please check and merge to main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants