Add the ability for pynamo to read + write map and list attributes #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| SHORT_ATTR_TYPES = [STRING_SHORT, STRING_SET_SHORT, NUMBER_SHORT, NUMBER_SET_SHORT, BINARY_SHORT, BINARY_SET_SHORT] | ||
| MAP = 'Map' | ||
| LIST = 'List' | ||
| SHORT_ATTR_TYPES = [STRING_SHORT, STRING_SET_SHORT, NUMBER_SHORT, NUMBER_SET_SHORT, BINARY_SHORT, BINARY_SET_SHORT, MAP_SHORT] |
| """ | ||
| rval = [] | ||
| for v in values: | ||
| if v is None: |
There was a problem hiding this comment.
I'm sensing a pattern with all of these.. surely we can write this in a generic way such that we don't need to do the type checks every time?
| @@ -257,3 +258,181 @@ def deserialize(self, value): | |||
| Takes a UTC datetime string and returns a datetime object | |||
| """ | |||
| return parse(value, dayfirst=False).datetime | |||
|
|
|||
|
|
|||
| class MapAttribute(Attribute): | |||
There was a problem hiding this comment.
so when I want to define an MapAttribute that requires verification, I need to create a subclass, otherwise I can use MapAttribute directly, right?
There was a problem hiding this comment.
bingo. for our user case we would just want to do
class CouponTemplate(MapAttribute):
code = UnicodeAttribute()
...
|
Changes Unknown when pulling da0246a on jmphilli:nested-validation into * on jlafon:devel*. |
| return all(self.is_type_safe(k, v) for k, v in six.iteritems(self._get_attributes())) | ||
|
|
||
| def serialize(self, values): | ||
| rval = dict() |
There was a problem hiding this comment.
nit: consistency use literal {}
|
LGTM! |
… conditional_operator
2 similar comments
|
Merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This allows pynamo to serialize + deserialize map and list types.