Use Attribute Name Based on Attribute Class #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmphilli
reviewed
Sep 18, 2016
| @@ -349,12 +349,12 @@ def update_item(self, attribute, value=None, action=None, conditional_operator=N | |||
| if len(expected_values): | |||
| kwargs.update(expected=self._build_expected_values(expected_values, UPDATE_FILTER_OPERATOR_MAP)) | |||
| kwargs[pythonic(ATTR_UPDATES)] = { | |||
| attribute: { | |||
| attribute_cls.attr_name: { | |||
There was a problem hiding this comment.
i wonder if we should pull the name out up here and save to a local var
There was a problem hiding this comment.
did you want to save it to a local var for readability?
There was a problem hiding this comment.
ya just so we don't have to keep accessing it that way.. seems error prone if someone changes this in the future, but may just be a matter of opinion
| ACTION: action.upper() if action else None, | ||
| } | ||
| } | ||
| if action is not None and action.upper() != DELETE: | ||
| kwargs[pythonic(ATTR_UPDATES)][attribute][VALUE] = {ATTR_TYPE_MAP[attribute_cls.attr_type]: value} | ||
| kwargs[pythonic(ATTR_UPDATES)][attribute_cls.attr_name][VALUE] = {ATTR_TYPE_MAP[attribute_cls.attr_type]: value} |
There was a problem hiding this comment.
we could then use that var here...
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use
attr_name, such that the name in the Dynamo database is different from the ORM, update_item would do the wrong thing and create a new attribute using the ORM name.This PR fixes that bug.