Make sessions threadsafe #234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I ran into the thread safety issue described here: pynamodb#153 According to boto3's docs, each thread should have its own session instance: http://boto3.readthedocs.io/en/latest/guide/resources.html#multithreading I resolved this by modifying the session property on the connection class. It makes self._session into a thread local variable, and attaches a session to self._session.session. The session property still has the same behavior, but now it's creating a session on a per-connection-per-thread basis instead of just on a per-thread basis. This issue was intermittent to begin with, and I hadn't figured out a way to reliably reproduce it, or I would have written a test. It still passes PynamoDB's unit tests, and I haven't run into the thread safety issue described in pynamodb#153 since I've been running the patched version.
4 similar comments
|
Not sure why the checks failed on Python 2.6. It doesn't look like it even executed the tests. |
…pynamodb#208) * Replace Delorean with dateutil, as dateutil is brought in by botocore * Update requirements and setup.py * Replace uses of Delorean * Fix test * Update deps to match botocore
Use pytest to run unit tests
|
Reopening with new default branch |
I ran into the thread safety issue described here: pynamodb#153 According to boto3's docs, each thread should have its own session instance: http://boto3.readthedocs.io/en/latest/guide/resources.html#multithreading I resolved this by modifying the session property on the connection class. It makes self._session into a thread local variable, and attaches a session to self._session.session. The session property still has the same behavior, but now it's creating a session on a per-connection-per-thread basis instead of just on a per-thread basis. This issue was intermittent to begin with, and I hadn't figured out a way to reliably reproduce it, or I would have written a test. It still passes PynamoDB's unit tests, and I haven't run into the thread safety issue described in pynamodb#153 since I've been running the patched version.
Open
|
replaced by #393 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into the thread safety issue described here:
#153
According to boto3's docs, each thread should have its own session instance:
http://boto3.readthedocs.io/en/latest/guide/resources.html#multithreading
I resolved this by modifying the session property on the connection
class. It makes self._session into a thread local variable, and
attaches a session to self._session.session. The session property still
has the same behavior, but now it's creating a session on a
per-connection-per-thread basis instead of just on a per-thread basis.
This issue was intermittent to begin with, and I hadn't figured out a
way to reliably reproduce it, or I would have written a test. It still
passes PynamoDB's unit tests, and I haven't run into the thread safety
issue described in #153 since I've been running the patched version.