New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firefox support #316
Firefox support #316
Conversation
…tifications into develop Conflicts: push_notifications/admin.py push_notifications/api/rest_framework.py push_notifications/apns.py push_notifications/models.py push_notifications/settings.py
Thanks. So this is webpush, no sense making it Firefox-specific imo. Just make sure that the url is swappable. The PR will have to be cleaned up to be merged, though - as it stands it's a fork pr. |
@goinnn What is this actually doing? So far I don't see where a message is sent. And I don't see any of the encryption that webpush requires. |
@jleclanche Every browser is very different. This implementation does not work for another browser, no sense swap the URL, although this url is set in the settings, for cleaning: https://github.com/goinnn/django-push-notifications/blob/develop/push_notifications/settings.py#L19
@jamaalscarlett The push on browser are without message... yes it is incredible!! The push system, e.g.: GCM sends a notification for the browser and the browser requests the message to the backend (payload view)... I have implemented this view and the model where the messages are saved ... So this if you are interested in webpush I can prepare a nice PR. |
@goinnn I'm still not sure I understand the purpose of https://github.com/jleclanche/django-push-notifications/pull/316/files#diff-2360c5d962b817cde3cabf9dae7c7547R6? webpush does allow you to send messages: |
@jamaalscarlett I have been studing the firefox push and I think firefox is currently the only browser that accept payload (messages): http://stackoverflow.com/questions/35950390/firefox-push-notifications-send-data-via-curl Am I right? |
@goinnn firefox is the only browser that uses the mozilla webpush spec. Chrome uses GCM and Safari uses APNS. I'm not sure what edge/internet explorer use. |
@goinnn If you use Chrome requires the Now that I am checking dates, maybe your initial PR precedes that stuff? I am not sure to be looking ad the correct dates. |
There is no actual functionality in this pull request. |
I'm sorry I know my PR is not very clean. In this PR you have firefox support.
I am going to do (in autumn) also Safari support and Edge support. Chrome is supported with GCM.
For browser you need a simple model to save the payload info, I have this model in another app, but I can move it.
Please tell me if you are interested in these supported