Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Willing to add unittest code #436

Closed
tonyyyye opened this issue May 8, 2018 · 1 comment
Closed

Willing to add unittest code #436

tonyyyye opened this issue May 8, 2018 · 1 comment

Comments

@tonyyyye
Copy link
Contributor

tonyyyye commented May 8, 2018

Just jumped from hearthbreaker.
Find that unittest is missing from fireplace and i have already added some.
Is that needed for this project?
@tonyyyye tonyyyye changed the title [TEST]Willing to add unittest code Willing to add unittest code May 9, 2018
@jleclanche
Copy link
Owner

Hi @tonyyyye, sorry for the slow reply

Tests are welcome, yes. Fireplace is unmaintained because I haven't really had the time for it since I moved full time on HearthSim, but if you swing by Discord, I'll be happy to help you with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jleclanche @tonyyyye