Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: do not refresh when expanding already selected node #208

Merged
merged 1 commit into from May 5, 2023

Conversation

jledentu
Copy link
Owner

@jledentu jledentu commented May 5, 2023

This PR early returns when expand tries to expand the already expanded node

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (19700fa) 96.66% compared to head (00d1694) 96.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
+ Coverage   96.66%   96.69%   +0.02%     
==========================================
  Files           8        8              
  Lines         270      272       +2     
  Branches       68       69       +1     
==========================================
+ Hits          261      263       +2     
  Misses          9        9              
Impacted Files Coverage Δ
src/utils/tree-model.js 99.26% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jledentu jledentu merged commit 58f018c into master May 5, 2023
10 checks passed
@jledentu jledentu deleted the do-not-expand-same-node branch May 5, 2023 22:50
github-actions bot pushed a commit that referenced this pull request May 5, 2023
## [4.1.1](v4.1.0...v4.1.1) (2023-05-05)

### Performance Improvements

* do not refresh when expanding already selected  node ([#208](#208)) ([58f018c](58f018c))
* do not refresh when expanding already selected  node ([#208](#208)) ([f2d55f3](f2d55f3))
@github-actions
Copy link

github-actions bot commented May 5, 2023

🎉 This PR is included in version 4.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

pull bot pushed a commit to mattdanielbrown/vue-finder that referenced this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant