Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elector is claiming the leadership before prometheus is actually ready #32

Closed
jlevesy opened this issue May 25, 2023 · 1 comment
Closed

Elector is claiming the leadership before prometheus is actually ready #32

jlevesy opened this issue May 25, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@jlevesy
Copy link
Owner

jlevesy commented May 25, 2023 •
edited
Loading

What's wrong

When a large WAL is already present, prometheus can take some time before actually be ready because it replays its WAL.

BUT: prometheus-elector claims leadership as soon as it starts. So if Prometheus takes some time to start, this can prevents falling back to another replica, which is already ready.

What could be nice is to wait for the sidecar Prometheus to be ready before actually trying to claim the leadership.
@jlevesy jlevesy added the bug Something isn't working label May 25, 2023
@jlevesy jlevesy mentioned this issue May 25, 2023
Merged
5 tasks
@jlevesy
Copy link
Owner Author

jlevesy commented May 25, 2023

Fixed in v1.1.0

@jlevesy jlevesy closed this as completed May 25, 2023
@jlevesy jlevesy mentioned this issue May 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jlevesy