New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Out-of-memory errors can be destructive #15
Comments
Ah, that's unfortunate and certainly not the intention! Before changing the docs I'd like to know what your issue is exactly. Do you have details or a way to reproduce? Look at repren line 335-346: If it was out of memory or out of disk on a giant file, it should abort before modifying the original. Do you know what path you were on and if there was a transform happening? What happened to your .orig file? |
I'll be doing a bit of testing in the coming days and will come back with details or close the issue as no-repro. Thanks for the suggestion re: using the source. Was using repren in a pipe, saw no .orig lying around after the crash, suspect PEBKAC on my side. |
Thanks. If it's used as a pipe there can be no .orig backup since the program won't have the file name. But in that case it also shouldn't be modifying the original, either, so that doesn't explain a destructive outcome. |
No repro so far. Closing. |
OK. It's important for repren to have essentially zero data-destructive issues for everyone to have confidence in it. If you do find/identify a data loss issue please reopen with details. |
...unless the user uses backups. Multi-gigabyte stuff can be tricky (lost one XXL-sized file this way, fortunately an intermediate result though), so I would add some words of caution into the help screens/README, viz. after the following passage:
insert this:
The text was updated successfully, but these errors were encountered: