New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add short Microsoft Windows section #361
Conversation
Welcome addition, thanks! Definitely willing to include a section like this. How about we call it "Windows only"? I'd like to clarify that other items may apply to Windows, but that the OS X and Windows sections are for items that only work on that platform. Secondly, I'm not a Windows user so would appreciate any review/feedback on this section from one or two more die-hard Windows folks! |
OK, I agree with a "Windows only" title. It matches the OS X section. I didn't use it, because the section was broader, proposing the use of Cygwin. |
I use Windows and Cygwin daily, so I hope my review will be useful. I took a quick glance through the rest of the document, and I don't see anything that doesn't also apply to Cygwin. So I think it is safe to include the Cygwin specific section. I have two suggestions:
But even without those changes, I think this an excellent addition to the document. I even learned something (about /dev/clipboard) even though I've been using Cygwin for years! |
@cstanhope thanks for the feedback. Links are very welcome. The lack of links is entirely due to laziness on my part. I can think of no reason to avoid (helpful and stable) links. More should be present for OS X, Windows, and throughout the doc, actually. |
Addresses: #issuecomment-175369010
@jlevy Thank you for the clarification regarding links. I was wondering whether this was a matter of style. |
Addresses: #issuecomment-175369010
Great. Since we've requested feedback, I'll leave this one open for another day in case there is anything else, and then merge in. |
I'd like to review and comment but need a few days, if you'll leave this open a little longer. Thanks. |
@cstanhope Thank you for the feedback. I incorporated the changes you suggested in 448887b. |
@dspinellis Your changes address my suggestions. Looks good! |
@JasonCoombs will you still review? |
Working on a write-up of suggestions today. Thanks for your patience. |
I'm still working on this, but please everyone see my request for discussion, here: #165 (comment) |
Add short Microsoft Windows section
Thanks for the discussion (will follow up more there shortly). I believe this is a solid addition, and doesn't preclude expansion or improvement, so have merged it in. Thank you @dspinellis ! And @JasonCoombs and @cstanhope for the comments. |
No description provided.