-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File format: unit=bytes makes startValue/endValue meaningless #406
Comments
Hi @vasi-stripe! I agree -- the Am I understanding you correctly, or are you envisioning situations where you'd specify both |
Good questions! For display in Speedscope as it currently exists, I agree there's not a real benefit to having meaningful startValue/endValue. But for use of the Speedscope format as a generalized interchange format, and/or for future extensions to Speedscope, it makes sense to think about time and weight differently. A few things one could do with this data:
Anyhow I'm not sure what the overall takeaway is here, just that this is something we can keep in mind as we think about the future of this file format! |
When unit=milliseconds, it's clear that it applies to both timestamps (like startValue) and to sample weights.
But when unit=bytes, there's no way to know what startValue/endValue are supposed to mean.
We should consider separate timeUnit and weightUnit fields.
The text was updated successfully, but these errors were encountered: