You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Your plugin looks cool, but what keeps me from using it is that it doesn't use CSS classes for its animations. I think using classes for your plugin would make the code much cleaner, and also adhere to the separation principle of style and structure of HTML / CSS.
The text was updated successfully, but these errors were encountered:
You’re absolutely right—the current nature of scrollReveal is that it lives in your markup, which does not follow the established best practice of separation of markup and presentation.
Issues #1 and #122 suggest a JavaScript API to address this very concern.
How about new keywords "classadd" and "classremove" that take a single parameter, namely the class to be added or removed. This could be useful in other scenarios as well. For instance, after rolling an object into place you might want to trigger a fancier animation without having to use the javascript callback.
Hi,
Your plugin looks cool, but what keeps me from using it is that it doesn't use CSS classes for its animations. I think using classes for your plugin would make the code much cleaner, and also adhere to the separation principle of style and structure of HTML / CSS.
The text was updated successfully, but these errors were encountered: