Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Classes for animations #143

Closed
MentalGear opened this issue May 1, 2015 · 2 comments
Closed

Using Classes for animations #143

MentalGear opened this issue May 1, 2015 · 2 comments

Comments

@MentalGear
Copy link

Hi,

Your plugin looks cool, but what keeps me from using it is that it doesn't use CSS classes for its animations. I think using classes for your plugin would make the code much cleaner, and also adhere to the separation principle of style and structure of HTML / CSS.

@jlmakes
Copy link
Owner

jlmakes commented May 4, 2015

Thanks @MentalGear

Welcome to GitHub.

You’re absolutely right—the current nature of scrollReveal is that it lives in your markup, which does not follow the established best practice of separation of markup and presentation.

Issues #1 and #122 suggest a JavaScript API to address this very concern.

🐝 #10 #97 #114

@jlmakes jlmakes closed this as completed May 4, 2015
@jayalfredprufrock
Copy link

How about new keywords "classadd" and "classremove" that take a single parameter, namely the class to be added or removed. This could be useful in other scenarios as well. For instance, after rolling an object into place you might want to trigger a fancier animation without having to use the javascript callback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants