Change data attribute to data-scroll-reveal

[jescalan]

So the standard way of using data- attributes is to have them as all lower case and separated by dashes. By using data-scrollReveal, this plugin breaks convention. This also has practical implications. The html5 api for interacting with data attributes specifies that while dataset keys can be camelCase, they are transformed to dash case before being selection. For example:

var el = document.createElement('div');
el.dataset.scrollReveal = 'foo';
document.body.appendChild(el);

...results in the following in the html:

<div data-scroll-reveal='foo'></div>

As such, where camelCase can and should be used with dataset selections in the javascript, the html data attribute should be dash cased. Alternately, if you wanted to keep scrollReveal as a single word, if you drop the camelCase, you can use data-scrollreveal instead.

[jlmakes]

This has been revisited; the attribute is now called data-sr

[jescalan]

👍