Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChangeModesOperation needs to send a notification that updates player fight/chase modes. #75

Open
jlnunez89 opened this issue Jul 18, 2020 · 1 comment
Labels
good first issue Good for newcomers

Comments

@jlnunez89
Copy link
Owner

jlnunez89 commented Jul 18, 2020

Problem:

Currently, when a ChangeModesOperation is executed, the player who's fight and chase modes changed is not made aware of the changes, essentially desynchronizing the modes seen in the client.

Solution:

  1. Create a new outgoing packet for OutgoingGamePacketType.PlayerModes under the namespace/folder Fibula.Communications.Packets.Outgoing:
    /// <summary>
    /// Updates a player's modes.
    /// </summary>
    PlayerModes = 0xA7,
    
  2. Create a new packet writer under the namespace/folder Fibula.Protocol.V772.PacketWriters for that new packet.
  3. Hook up the new packet writer in Fibula.Protocol.V772.CompositionRootExtensions class.
  4. Finally, in ChangeModesOperation.Execute, add a new notification that sends the new packet to the player, to update their modes.
@jlnunez89 jlnunez89 added the good first issue Good for newcomers label Jul 18, 2020
@jlnunez89
Copy link
Owner Author

Intentionally left up for grabs for any brave soul who wants to contribute to wet their feet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Development

No branches or pull requests

1 participant