Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps #125

Merged
merged 3 commits into from Jan 12, 2017
Merged

Update deps #125

merged 3 commits into from Jan 12, 2017

Conversation

hzoo
Copy link
Contributor

@hzoo hzoo commented Jan 11, 2017

recast isn't used since it's forked inline in src

@jlongster
Copy link
Member

Oh right, thanks! You need to remove the recast import in tests_config/run_spec.js. We used to use it in there but not anymore.

Copy link
Member

@jlongster jlongster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@hzoo
Copy link
Contributor Author

hzoo commented Jan 11, 2017

Oops missed that one! (only checked source), updated

@@ -1,7 +1,6 @@
"use strict";
const fs = require('fs');
const jscodefmt = require("../");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably we should change this to prettier as well. 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do that in a follow-up!

@jlongster jlongster merged commit ea084dc into prettier:master Jan 12, 2017
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jan 21, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants