Last argument expansion works for arrow functions that return JSX #211
Conversation
| @@ -1720,7 +1720,8 @@ function printArgumentsList(path, options, print) { | |||
| lastArg.type === "FunctionExpression" || | |||
| lastArg.type === "ArrowFunctionExpression" && | |||
| (lastArg.body.type === "BlockStatement" || | |||
| lastArg.body.type === "ArrowFunctionExpression") || | |||
| lastArg.body.type === "ArrowFunctionExpression" || | |||
There was a problem hiding this comment.
Is there a reason why we have to enumerate all the types of body we want to support? Could I just get rid of the check on body.type?
There was a problem hiding this comment.
I worked through this on my livestream, and had the exact same question! I removed the body.type check and saw why from the tests. I can't remember exactly why, but try it out.
I think the part of the reason is #61 actually. We allowed block-less arrow functions to break on the content, so if you have x => this.foo().bar(), it could actually break right after the arrow. That would look weird though, or even totally broken if there is more complex content, if we allow this last arg grouping behavior. So we only break blocks.
However, turns out of course there are other things we want to allow to break: objects, arrays, etc. But not everything. Feel free to think about this and let me know if there's a better solution! I'm fine if there's a different way that works for everything.
|
I added a second commit on-top that fixes #130. It makes sure that not only JSXElement but also objects and arrays do not add another level of indentation. |
|
Awesome! There might be a way to make this code simpler. Until then, this works. |
lock
bot
added
the
locked-due-to-inactivity
Fixes #195
Fixes #130