Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too big for the GitHub API #8613

Closed
1 task
jlord opened this issue Jan 26, 2016 · 5 comments
Closed
1 task

Too big for the GitHub API #8613

jlord opened this issue Jan 26, 2016 · 5 comments

Comments

@jlord
Copy link
Owner

jlord commented Jan 26, 2016

As of Jan. 11th the index.html file became over 1MB and too large to use with the GitHub API so it is not being rebuilt with new names (though new names are still being collected). There are a few options:

  • Use the Git Data API
    • Pro: don't have to worry about size in future
    • Potential Con: Ahh, use Git Data API
  • Render the page client-side
    • Pro: don't get limited by API
    • Potential Con: slow website loading lots of elements
      • test this out
  • Use Jekyll
    • Pro: Jekyll does the hefty lifting, don't get limited by API
    • Con: users can't view the site themselves without knowing Jekyll
  • Only show last 100 or 200 names (leaning towards this option)
    • Pro: File stays small
    • Con: Everyone's name isn't there forever, but this is probably just a small con.
@M1kep
Copy link
Contributor

M1kep commented Feb 7, 2016

So currently where is it failing?

@jlord
Copy link
Owner Author

jlord commented Feb 7, 2016

@M1kep I went through my server logs and found where it was failing and where I got the response from GitHub that the file was too big and to use the Git Data API. The file currently using the regular API—

https://github.com/jlord/reporobot/blob/master/buildpage.js

I'm adding another option to the list up above which is to just how the last 100 or 200 on the page rather than all. I'm guessing not many come back to see their name in the list and so long as we have the number of all who have completed it, it should still feel impactful. I'm leaning towards this option now.

@jlord
Copy link
Owner Author

jlord commented Feb 17, 2016

Woot, page is back up and fixed now ✨ 🍕

@jlord jlord closed this as completed Feb 17, 2016
@thegerscheffect
Copy link
Contributor

is it possible to only show the newest additions in contributors folder?

@jlord
Copy link
Owner Author

jlord commented Mar 28, 2016

@thegerscheffect Yep, that's what it does now, it just shows the last 100—http://jlord.us/patchwork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants