Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation Tracking #106

Open
29 of 35 tasks
jlouis opened this issue Oct 30, 2017 · 7 comments
Open
29 of 35 tasks

Validation Tracking #106

jlouis opened this issue Oct 30, 2017 · 7 comments

Comments

@jlouis
Copy link
Owner

jlouis commented Oct 30, 2017

Background

We need to have a place where we track validations. We begin this work by building the complete list, then mark what we already have covered. Things not covered are pulled into their own issues for further tracking.

Checklist

From the Oct2016 specification:

  • 5.1.1 Named Operation Definitions
  • 5.1.1.1 Operation Name Uniqueness
  • 5.1.2 Anonymous Operation Definitions
  • 5.1.2.1 Lone Anonymous Operation
  • 5.2.1 Field Selections on Objects, Interfaces, and Unions Types
  • 5.2.2 Field Selection Merging
  • 5.2.3 Leaf Field Selections
  • 5.3.1 Argument Names
  • 5.3.2 Argument Uniqueness
  • 5.3.3 Argument Values Type Correctness
  • 5.3.3.1 Compatible Values
  • 5.3.3.2 Required Non-Null Arguments
  • 5.4.1 Fragment Declarations
  • 5.4.1.1 Fragment Name Uniqueness
  • 5.4.1.2 Fragment Spread Type Existence
  • 5.4.1.3 Fragments On Composite Types
  • 5.4.1.4 Fragments Must Be Used
  • 5.4.2 Fragment Spreads
  • 5.4.2.1 Fragment spread target defined
  • 5.4.2.2 Fragment spreads must not form cycles
  • 5.4.2.3 Fragment spread is possible
  • 5.4.2.3.1 Object Spreads In Object Scope
  • 5.4.2.3.2 Abstract Spreads in Object Scope
  • 5.4.2.3.3 Object Spreads In Abstract Scope
  • 5.4.2.3.4 Abstract Spreads in Abstract Scope
  • 5.5.1 Input Object Field Uniqueness
  • 5.6.1 Directives Are Defined
  • 5.6.2 Directives Are In Valid Locations
  • 5.6.3 Directives Are Unique Per Location
  • 5.7.1 Variable Uniqueness
  • 5.7.2 Variable Default Values Are Correctly Typed
  • 5.7.3 Variables Are Input Types
  • 5.7.4 All Variable Uses Defined
  • 5.7.5 All Variables Used
  • 5.7.6 All Variable Usages are Allowed
@jlouis
Copy link
Owner Author

jlouis commented Oct 30, 2017

PR #71 tracks 5.7.4, PR #70 tracks 5.7.6

@jlouis
Copy link
Owner Author

jlouis commented Oct 30, 2017

The checked validations are already handled by the code base with a test.

@jlouis
Copy link
Owner Author

jlouis commented Oct 30, 2017

PR #108 tracks 5.2.2

@jlouis
Copy link
Owner Author

jlouis commented Oct 30, 2017

5.3.3.1 is handled already by the type checker.

@jlouis
Copy link
Owner Author

jlouis commented Oct 30, 2017

5.3.3.2 is also handled by the type checker.

@jlouis
Copy link
Owner Author

jlouis commented Oct 30, 2017

PR #109 tracks 5.4.1.4

@jlouis
Copy link
Owner Author

jlouis commented Nov 2, 2017

A large number of issues were closed just now, so update the checklist with those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant