Issue 63: Create a play_file attribute for entries to to show which file to link to from play online #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danshiovitz
commented
Oct 6, 2016
|
|
||
| Otherwise, this information will appear someday... | ||
| Copy `conf/ifcomp_local.conf-dist` to `conf/ifcomp_local.conf` and then update the database pointers therein as appropriate. |
There was a problem hiding this comment.
The instructions previously said "ifcomp.local" but that didn't match what was in IFComp.pm
danshiovitz
commented
Oct 6, 2016
| else { | ||
| $redirection_target = 'index.html'; | ||
| } | ||
| $redirection_target = $entry->play_file->stringify; |
There was a problem hiding this comment.
play_file is a File object holding a relative path
danshiovitz
commented
Oct 6, 2016
| @@ -647,78 +662,98 @@ sub _build_subdir_named { | |||
| return $path; | |||
| } | |||
|
|
|||
| sub _build_platform { | |||
| sub _build_contents_data { | |||
There was a problem hiding this comment.
I've avoided some of the prior uses of basename here since in theory this should be able to identify play_files within subdirectories in the zipfile.
…ile to link to from play online, instead of assuming index.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes it so at the time the platform is generated (by analyzing the uploaded files), it also picks one file as the play_file. For the web platforms, this file is linked to by play online (the play file doesn't get used for the non-web platforms, but you can imagine down the line the site could generate a custom parchment build based on the file or something).