Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global pollution #15

Closed
cscalfani opened this issue Dec 29, 2013 · 3 comments
Closed

Global pollution #15

cscalfani opened this issue Dec 29, 2013 · 3 comments

Comments

@cscalfani
Copy link

Wouldn't it be better to not pollute the global namespace with suspenderStack and instead place it in Suspender, i.e. Suspender. suspenderStack. Also, why can't you do the same for the other global functions, setActiveSuspender, getActiveSuspender, clearActiveSuspender, etc.

@jmar777
Copy link
Owner

jmar777 commented Dec 31, 2013

Hey, thanks for filing an issue. There's actual no global pollution there - those "globally" defined variables aren't exposed outside of the module unless explicitly exported. I'll probably have to address those once browser compatibility is added, though...

Did you happen to observe any actual global pollution going on, or was that simply based on browsing the code?

@cscalfani
Copy link
Author

My concern was raised when I was browsing the code. I was thinking about the browser. From your comment, it's clear that it's not supported yet. Had I looked at the code more carefully, I would have seen module.exports.

@jmar777
Copy link
Owner

jmar777 commented Dec 31, 2013

Sounds like we're good then - thanks for taking the time to report it anyway :)

@jmar777 jmar777 closed this as completed Dec 31, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants