You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Wouldn't it be better to not pollute the global namespace with suspenderStack and instead place it in Suspender, i.e. Suspender. suspenderStack. Also, why can't you do the same for the other global functions, setActiveSuspender, getActiveSuspender, clearActiveSuspender, etc.
The text was updated successfully, but these errors were encountered:
Hey, thanks for filing an issue. There's actual no global pollution there - those "globally" defined variables aren't exposed outside of the module unless explicitly exported. I'll probably have to address those once browser compatibility is added, though...
Did you happen to observe any actual global pollution going on, or was that simply based on browsing the code?
My concern was raised when I was browsing the code. I was thinking about the browser. From your comment, it's clear that it's not supported yet. Had I looked at the code more carefully, I would have seen module.exports.
Wouldn't it be better to not pollute the global namespace with
suspenderStack
and instead place it inSuspender
, i.e.Suspender. suspenderStack
. Also, why can't you do the same for the other global functions,setActiveSuspender
,getActiveSuspender
,clearActiveSuspender
, etc.The text was updated successfully, but these errors were encountered: