Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query changesets with more than 100 results #23

Merged
merged 3 commits into from
Jun 9, 2024

Conversation

jmaspons
Copy link
Collaborator

@jmaspons jmaspons commented Jun 9, 2024

Make multiple requests if limit > 100 (API limited to 100) and unite results

* Fix requests parameter time when time and time_2 parameters are present
* .osm_query_changesets() is an intern function and expects correct input
* set the default limit from getOptions(osmapir.api_capabilities)
Avoid API error:
! HTTP 400 Bad Request.
• cannot use order=oldest with time

Remove unused code paths
Copy link

codecov bot commented Jun 9, 2024

Codecov Report

Attention: Patch coverage is 92.94118% with 6 lines in your changes missing coverage. Please review.

Project coverage is 92.93%. Comparing base (b9597c2) to head (d81aa20).

Files Patch % Lines
R/osm_query_changesets.R 93.58% 5 Missing ⚠️
R/osmapi_changesets.R 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   92.68%   92.93%   +0.24%     
==========================================
  Files          22       23       +1     
  Lines        2050     2108      +58     
==========================================
+ Hits         1900     1959      +59     
+ Misses        150      149       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmaspons jmaspons merged commit fea458c into main Jun 9, 2024
9 checks passed
@jmaspons jmaspons deleted the query_chageset_pagination branch June 9, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant