Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding IntelliSense support for Ionic #31

Open
jmatthiesen opened this issue Oct 15, 2015 · 1 comment
Open

Adding IntelliSense support for Ionic #31

jmatthiesen opened this issue Oct 15, 2015 · 1 comment

Comments

@jmatthiesen
Copy link
Contributor

I'm planning to make a version of this Angular extension so that it works with Ionic. It should be as simple as:

  1. Creating a copy of angular.intellisense.js and naming it ionic.bundle.intellisense.js
  2. Adding a call to trackModule('ionic'); after the existing trackModule('ng');

However, I don't want to make a full copy of angular.intellisense.js in source control, because we risk not having changes stay in sync between the two files. What do you think of the following design proposal?

Proposal

  1. Refactor common code into an IntelliSenseExtension.js file that has the shared source for both frameworks (this is most of the code).
  2. Create an angular.suffix.js file with the code that is unique to Angular (i.e. trackModule('ng');)
  3. Create an ionic.suffix.js file with the same unique code for Ionic (i.e. trackModule('ionic');)
  4. Use Gulp and a gulpfile.js build script that takes the common code and suffix files and outputs both angular.intellisense.js and ionic.bundle.intellisense.js
  5. Add a dist folder to this repo that contains the build output for anyone that just wants to download and use the built files.
@jmbledsoe
Copy link
Owner

I am honestly fine with whatever. I haven't been in a position to contribute to this project lately (new job), and I'm not working much with AngularJS anymore, so I don't have strong opinions about it. If you have vision, then run with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants