Fixed: Parsing of empty select boxes failed #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sed InvalidNameError.
This commit ensures that the tests pass no matter the user has installed whichever parsing library with bs4.
**Explanation:**
When using lxml (recommended parser in BeautifulSoup4) the parsing is little different then the inbuilt parser:
BeautifulSoup('<input name="hi">')
# gives "<html><body><input name='hi' /></body></html>"
# while the inbuilt parser gives "<input name='hi' />"
# Thus the add_field function used to fail by giving InvalidNameError
The parsing of complicated forms is way much better using `lxml` and RoboBrowser compliments it well.
The only issue caused was due to the individual field parsings.
Forcing inbuilt parser for fields parsing fixes the issues with individual fields while ensuring the efficiency of lxml for parsing of forms.
|
Hi @jmcarp, RoboBrowser tests fail if we have the Do let me know if you need any more details related to the issue. Thanks. |
|
Thanks for the fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Joshua,
RoboBrowser failed to parse forms where there were empty select boxes. I have added the tests as well as the fix for the same.
The use cases of empty select boxes are pretty common on ASP website where forms require multiple submits. Before the initial submit the select boxes are kept empty. On initial submit, the select boxes get a few options based on other values.
Do let me know if anything is required to be modified in the pull request.
Pratyush