Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup.py is missing license header #50

Closed
nedn opened this issue Sep 3, 2015 · 1 comment
Closed

setup.py is missing license header #50

nedn opened this issue Sep 3, 2015 · 1 comment
Labels
infrastructure

Comments

@nedn
Copy link

nedn commented Sep 3, 2015

To whom it may concern,
We are using pyfakefs as third_party in chromium project. The file pyfakefs/setup.py is missing license header and make chromium license check fails. My current workaround is copying the license header from other files in the project into it.
It would be great if someone can update the license header in pyfakefs/setup.py so we can make the pyfakefs pass Chromium license check without modification.

Thanks,
Ned
@jmcgeheeiv
Copy link
Contributor

Please see if the license is now satisfactory. If not, please direct me to an example showing a setup.py that meets your requirements.

vinterstum pushed a commit to catapult-project/catapult that referenced this issue Feb 4, 2016
@nedn
[Telemetry] Add pyfakefs to telemetry/third_party
b9217a1 
BUG about pyfakefs/setup.py's license header: pytest-dev/pyfakefs#50

BUG=527952

Review URL: https://codereview.chromium.org/1310343005

Cr-Commit-Position: refs/heads/master@{#347292}
vinterstum pushed a commit to catapult-project/catapult that referenced this issue Feb 4, 2016
@nedn
[Telemetry] Update pyfakefs to latest revision.
035e94f 
BUG=pytest-dev/pyfakefs#50

Review URL: https://codereview.chromium.org/1313163007

Cr-Commit-Position: refs/heads/master@{#347815}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nedn @jmcgeheeiv @mrbean-bremen