New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py is missing license header #50

Closed
nedn opened this Issue Sep 3, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@nedn

nedn commented Sep 3, 2015

To whom it may concern,
We are using pyfakefs as third_party in chromium project. The file pyfakefs/setup.py is missing license header and make chromium license check fails. My current workaround is copying the license header from other files in the project into it.
It would be great if someone can update the license header in pyfakefs/setup.py so we can make the pyfakefs pass Chromium license check without modification.

Thanks,
Ned

@jmcgeheeiv jmcgeheeiv closed this in c307a36 Sep 5, 2015

@jmcgeheeiv

This comment has been minimized.

Show comment
Hide comment
@jmcgeheeiv

jmcgeheeiv Sep 5, 2015

Owner

Please see if the license is now satisfactory. If not, please direct me to an example showing a setup.py that meets your requirements.

Owner

jmcgeheeiv commented Sep 5, 2015

Please see if the license is now satisfactory. If not, please direct me to an example showing a setup.py that meets your requirements.

vinterstum pushed a commit to catapult-project/catapult that referenced this issue Feb 4, 2016

[Telemetry] Add pyfakefs to telemetry/third_party
BUG about pyfakefs/setup.py's license header: jmcgeheeiv/pyfakefs#50

BUG=527952

Review URL: https://codereview.chromium.org/1310343005

Cr-Commit-Position: refs/heads/master@{#347292}

vinterstum pushed a commit to catapult-project/catapult that referenced this issue Feb 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment