Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to pytest-dev organization #590

Closed
mrbean-bremen opened this issue Mar 5, 2021 · 12 comments
Closed

Move to pytest-dev organization #590

mrbean-bremen opened this issue Mar 5, 2021 · 12 comments
Assignees

Comments

@mrbean-bremen
Copy link
Member

mrbean-bremen commented Mar 5, 2021

As discussed with @jmcgeheeiv, it would be a good idea to transfer this repo to the pytest-dev organization. This would help to ensure continued maintenance, and also possibly to get more eyes for issues and code reviews (given enough eyeballs...).

While pyfakefs is not only a pytest plugin, as it can also be used with other test frameworks, pytest-dev seems like a good match, as the majority of new pyfakefs users seem to use it via the fs fixture, and improving pytest support is a sensible goal for pyfakefs.

We seem to meet most of the preconditions, except the name (nothing we can do about this, changing it now would not be a good idea), and the authors info, which can easily be added.

The first step will be to clarify if pyfakefs is feasible for pytest-dev - I will write a respective mail in the pytest-dev list, and we can go on from there of we get a go.

cc @nicoddemus

@jmcgeheeiv
Copy link
Contributor

I also offer domain pyfakefs.org to the PyTest community.

If you do not care for it I will continue to maintain it and point it to the right location for a few years at least.

@mrbean-bremen
Copy link
Member Author

Unfortunately, it turned out that pyfakefs seems not really to fit into pytest-dev.
There has been a couple of suggestions for another organization: PyCQA, which I don't think will fit, as it is almost exclusively about linting tools, and a new organization cogs-of-testing, which was meant to be about testing, but is still empty.
I still like the idea about transfer to an organization for obvious reasons, and still think that pytest-dev would fit best of the existing ones, but as long as there is no fitting organization, I see no real way to do this at the moment.

Sorry about that - I really thought that this would work...

@jmcgeheeiv
Copy link
Contributor

I think it was a good idea to propose it. If the other organizations do not care for pyfakefs, that is their prerogative.

@mrbean-bremen
Copy link
Member Author

Closing this for now.

@mrbean-bremen
Copy link
Member Author

mrbean-bremen commented Oct 5, 2022

Reopen as the move is now approved.

Some things to do:

  • transfer the repo to @nicoddemus
  • adapt all URLs in the README and documentation
  • change master to main, while at it
  • optional: add automatic release to PyPi

@mrbean-bremen mrbean-bremen reopened this Oct 5, 2022
@nicoddemus
Copy link
Member

Just to make sure we are on the same page, the first step would be to transfer the ownership of the repository to one of the pytest-dev core maintainers (I volunteer).

@jmcgeheeiv jmcgeheeiv self-assigned this Oct 6, 2022
@jmcgeheeiv
Copy link
Contributor

Transfer to @nicoddemus requested.

@jmcgeheeiv jmcgeheeiv assigned nicoddemus and unassigned jmcgeheeiv Oct 6, 2022
@nicoddemus
Copy link
Member

Thanks folks!

Move has been completed, invite sent to @jmcgeheeiv to join the pytest-dev organization. 👍

@mrbean-bremen
Copy link
Member Author

I plan to make a 5.0 release soon, where the automatic release will be tested. Hopefully not forgetting anything for that...

@nicoddemus
Copy link
Member

nicoddemus commented Oct 8, 2022

In case you want a template, you can take a look at: https://github.com/pytest-dev/pytest-mock/blob/main/.github/workflows/deploy.yml

You need to create a pypi_token secret in this repository with an upload token from PyPI, then you can just drop it in the .github folder and it will work. 👍

EDIT: nvm, just noticed you opened a PR already.

@mrbean-bremen
Copy link
Member Author

mrbean-bremen commented Oct 9, 2022

Ok, the release workflow is working on second try, but Read the Docs does not trigger. Maybe I misconfigured something or removed too much...
Seemed to be a problem with the browser cache. Still the selection menu for another version is incorrect, but maybe this is also some caching problem, I will observe this. The direct links from README work.

@mrbean-bremen
Copy link
Member Author

So... thanks everyone - move complete!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants