Add check if subtype matches when answering a DNSQuestion #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: siedlerchr <siedlerkiller@gmail.com>
|
Failing CI reports something with403 when accessing github api |
kaikreuzer
requested changes
Apr 7, 2024
| @@ -1174,7 +1174,22 @@ public Collection<DNSRecord> answers(DNSRecordClass recordClass, boolean unique, | |||
| List<DNSRecord> list = new ArrayList<DNSRecord>(); | |||
There was a problem hiding this comment.
In order to avoid code duplication, could this method simply call the newly introduced method with subType parameter set to null?
| return list; | ||
| } | ||
|
|
||
| public Collection<DNSRecord> answers(DNSRecordClass recordClass, boolean unique, int ttl, HostInfo localHost, String subType) { |
There was a problem hiding this comment.
As this is a public method, please add a brief JavaDoc to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #267