Add failing test for hasChanges after loading relations #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 9b2b261 on TimothyKrell:hasChangesLoadRelations into * on jmdobry:master*. |
jmdobry
added a commit
that referenced
this pull request
Sep 15, 2014
Add failing test for hasChanges after loading relations
|
These test have been merged. With the fix to #165 they pass now. |
|
Awesome! Thanks for fixing. This was my first pull request to an open source project. Hurray! On Mon, Sep 15, 2014 at 10:43 AM, Jason Dobry notifications@github.com
|
|
Yeah thanks! If you ever have an overwhelming urge to write more tests, knock yourself out! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After an item has been injected into the data store and it's relations have been loaded,
DS.hasChanges()reports that there are changes, when there shouldn't be.DS.changes()shows that thelocalFieldsare what have been added.