Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[styling] Consider keeping the branding of the JMESPath logo #64

Closed
springcomp opened this issue Apr 20, 2022 · 5 comments
Closed

[styling] Consider keeping the branding of the JMESPath logo #64

springcomp opened this issue Apr 20, 2022 · 5 comments

Comments

@springcomp
Copy link
Contributor

This is part of a series or minor issues that aim to enable support for flexible styling and theming of the JMESPath site.

I feel the JMESPath logo is part of the original branding and should not be changed,
Here is the original logo:

image

Here is the new logo:

image

In particular the "Path" portion of the logo used to be in all uppercase. Whereas the "JME" portion of the logo used to be formatted with a very thin font.

@innovate-invent
Copy link
Collaborator

I took some artistic liberty to resolve some minor issues.

Everywhere else JMESPath is written, it is lowercase "ath". I felt it would be good to make it consistent and helps make it visually distinct from the JMES portion. I also extended the J to hang down to visually incorporate the "Community Edition" subheading. "JME" was made thicker to improve readability, especially when it is displayed at a smaller size. "Path" was changed to black from white to be compatible with a transparent background, this allows it to better integrate with surrounding styling rather than forcing a background color. I still need to produce a stylesheet for the svg that will allow swapping the colors for compatibility with a dark background.

Is there a downside to taking this opportunity to update the the branding? The changes are minor enough that it is still recognizable with the original. I think that we should make some effort to not confuse people between our fork and James'.

I am not married to any of these changes if you feel we really should stick to the original logo.

@springcomp
Copy link
Contributor Author

I guess you have some good reasoning behind the changes you made.
Maybe let's keep it as you've done. We will always be able to respond to feedback from the community, if any at all.

@innovate-invent
Copy link
Collaborator

innovate-invent commented Apr 20, 2022

jmespath

Here is a prototype with the uppercase path

@springcomp
Copy link
Contributor Author

Here is a prototype with the uppercase path
I admit to prefer this one 😏

@innovate-invent
Copy link
Collaborator

sure, I will swap that one into the repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants