Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security addition - Optionally Separate the username and password from main library #436

Open
shijocj1978 opened this issue Sep 11, 2023 · 0 comments

Comments

@shijocj1978
Copy link

shijocj1978 commented Sep 11, 2023

Currently, other than using the username and password to login directly from library, there is no way to inject the authenticated token directly and then save it in pickle file. every time user uses the API they need to pass username, password and 2FA info through wires since they have no idea it is expired.

I wrote a separate standalone Azure function which calls the the login function and returns the token format which is same as pickle file. (includes device_token). This will be used by application to inject the token and then save token into the pickle locally.

Benefit of this approach is to have an additional layer of security where my mobile app or service server will not have to store /pass the username and password and 2FA auth info and will not be compromised incase of a security event. I call my azure function with a RSA token and then get the authenticated token back which will be pushed into library.

I have this change in my local branch and wondering this would be nice addon. If others feeling this is a good addon, I can get the changes for a review and merge it eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant