Set TLS verification according to VAULT_SKIP_VERIFY #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. Can you address the clippy and format errors? Also, I just merged #30 which adds a test file for testing client code (tests/client.rs). Can you please move your tests to that file? |
|
Sure. I will do that today. |
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is an attempt to fix the issue #31.
The difference here (when compared to
strconv.ParseBool) is that in the original Vault implementation any other value returns an error, and here I'm keeping the default astrue(at least for now) to avoid modifying the function's signature.I added
serial_testto dev-dependencies to make the tests related to this feature run sequentially, and avoid one test to overwrite theVAULT_SKIP_VERIFYvalue previously set by the other.Please let me know if there is anything I need to fix.