Adds GitHub Party Parrot #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deedeelavinder
force-pushed
the
github_parrot
branch
from
6c1c4a8
to
0bbd104
Compare
|
Looks like this build and the one previous have both failed due to two failing tests with the same error, one for SD and one for HD: Happy to help sort it out if needed. |
deedeelavinder
force-pushed
the
github_parrot
branch
from
0bbd104
to
f5a2849
Compare
jmhobbs
reviewed
Oct 31, 2018
| @@ -31,7 +31,7 @@ | |||
| {"username":"marcthayer","contributions":[{"pr":78,"action": "banana parrot"},{"pr":77,"action": "typo fixes"}]}, | |||
| {"username":"tianyuliu","contributions":[{"pr":81,"action":"ski parrot"},{"pr":80,"action":"halal parrot"},{"pr":84,"action":"ship it parrot"}]}, | |||
| {"username":"vaicine","contributions":[{"pr":89,"action":"nyan parrot"}]}, | |||
| {"username":"deedeelavinder","contributions":[{"pr":90,"action":"love parrot"},{"pr":130,"action":"taco parrot"}]}, | |||
| {"username":"deedeelavinder","contributions":[{"pr":90,"action":"love parrot"},{"pr":130,"action":"taco parrot"},{"pr":266,"action":"github party parrot"}]}, | |||
There was a problem hiding this comment.
Nice! I always forget to update these.
|
Not sure what is up with that test, I'll open another issue for it, you're more than welcome to help me sort that out if you have a moment. Thanks for the new parrot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea for this one came from Issue #126, a slight variation on the request.