General housekeeping - Rename, Relocate & Remove Parrots #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To parrots.json file underneath jediparrot for nice continuity.
To work with Google sign in instead.
With an if statement and a new arg that allows the user to sign in with Google or not.
To be easier for the user (a simple y/n instead of true/false) and nicer code (single if comparison of an uppercase arg). Also contains error handling accidental (or deliberate) invalid arg errors.
To instruct on the new google arg when using the auto uploader script.
To improve readability of the auto upload command.
To make the --google arg optional and to replace .sleep with a smoother and better alternative.
To reflect auto uploader script changes specifically the updated args.
To remove unecessary comparison and error handling else.
To update forked repo.
These parrots are only available in their HD form so should not be in the SD folder
Britparrot exists as unitedkingdomparrot in parrot flags so should be removed from the main set
Instructions for naming standards in the contributions section of the README
|
Apologies for the lingering git history. My fork wasn't purged prior to these changes being made. Only the commits from 26/03/2019 onward matter. |
|
No worries, I'll squash 'em up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to this issue
All parrots with inconsistent naming have been renamed to a [name]parrot.gif standard.
parrotwaveXbeing renamed towaveXparrotcan be reverted if the current way it's named is preferred.All HD parrots in the SD folder have been moved to the HD folder.
githubparrot,portalblueparrot&portalorangeparrotare only available in an HD version (no smaller SD version exists) so they have been removed from the SD folder.britparrothas been removed asunitedkingdomparrothas been added to the flags folder and they are identical.README updated to instruct new contributors on the naming standard.