Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JPQL Filter ignores the value component for the custom condition case #2661

Closed
KremnevDmitry opened this issue Dec 20, 2023 · 1 comment
Closed
Assignees
Labels
in: ui size: S state: won't fix This will not be worked on type: bug Something isn't working ver: 1 Jmix version 1.x

Comments

@KremnevDmitry
Copy link
Contributor

KremnevDmitry commented Dec 20, 2023

Environment

Jmix version: 1.5.4, 2.1.1 (#2662)
Jmix Studio plugin version: 2.1.1-233
IntelliJ version: IntelliJ IDEA 2023.3 (Ultimate Edition)

Bug Description

See: https://forum.jmix.io/t/jpqlfilter-custom-filter-field/4157
For some reason, the JPQL filter in the custom condition of the Filter component ignores the custom component.

Steps To Reproduce

  1. Run the attached project
  2. Open the PetBrowser screen
  3. Open the tab with the filter component
  4. Add both custom conditions for the filter

Current Behavior

The property filter has options:
image

The jpql filterhas no options:
image

Expected Behavior

Both filters have the same set of options.

Sample Project

jmix-petclinic.zip

@KremnevDmitry KremnevDmitry added type: bug Something isn't working ver: 1 Jmix version 1.x triage Issue is waiting for triage labels Dec 20, 2023
@gorbunkov gorbunkov removed the triage Issue is waiting for triage label Dec 22, 2023
@gorbunkov gorbunkov added this to Backlog in Release 1.5 via automation Dec 22, 2023
@gorbunkov gorbunkov removed this from Backlog in Release 1.5 Feb 14, 2024
@KremnevDmitry KremnevDmitry added the state: won't fix This will not be worked on label Apr 17, 2024
@KremnevDmitry
Copy link
Contributor Author

Using valueComponents as they are is impossible for filter conditions and configurations.
This is a consequence of the fact that valueComponents are stored in the entity [FilterValueComponent] for conversion into the model representation of the filter.
See: io.jmix.ui.component.propertyfilter.PropertyFilterConverter#convertValueComponentToComponent

Thus, a valueComponent can only be described by a limited set of properties (componentName and styleName).

Incorrect loading of options was due to an incorrect component generation strategy for the JpqlFilter, fixed in #2516

Closed.

@KremnevDmitry KremnevDmitry closed this as not planned Won't fix, can't repro, duplicate, stale Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: ui size: S state: won't fix This will not be worked on type: bug Something isn't working ver: 1 Jmix version 1.x
Projects
None yet
Development

No branches or pull requests

2 participants