Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release as a Ruby gem? #27

Open
zorab47 opened this issue Nov 10, 2023 · 5 comments
Open

Release as a Ruby gem? #27

zorab47 opened this issue Nov 10, 2023 · 5 comments

Comments

@zorab47
Copy link

zorab47 commented Nov 10, 2023

Would it be possible to release this as a gem to embed the functionality and jobs into existing apps? An initial review leads me to believe that use of Rails is minimal for the periodic jobs, which does make use of ActiveJob.

I'll check into the feasibility of it if ya'll are open to the idea. 😄

@jmkoni
Copy link
Owner

jmkoni commented Nov 10, 2023

Absolutely open to it! I’m guessing it might need a fork, but it sounds like a good idea.

@zorab47
Copy link
Author

zorab47 commented Nov 10, 2023

A quick rundown of my thoughts on a gem is below. I do want to keep the functionality centralized here (in this repo) for ease of development and maintainability. Plus it is your awesome code. 🚀

  1. Move the job and models into lib/slack_pairs where gems put their code
  2. Update the Rails app to make use of lib/slack_pairs
  3. Move many of the static strings into I18n translations that can be customized per deploy
  4. Add a slack_pairs.gemspec file that packages lib/ as a gem. It could then be released and integrated into other apps

There's potential to make this a Rails Engine, but that'll be extra effort outside the scope of my objective.

Thoughts or concerns?

@jmkoni
Copy link
Owner

jmkoni commented Nov 10, 2023

Sounds good to me. Might be a good start and maybe I can pull out mod tools into a second gem. I’ve been meaning to make this more flexible, just haven’t had the time yet.

@zorab47
Copy link
Author

zorab47 commented Nov 29, 2023

I've started a branch here: zorab47#1

@jmkoni
Copy link
Owner

jmkoni commented Nov 29, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants