Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't resize other windows when resizing floats #207

Merged
merged 1 commit into from
Apr 29, 2023

Conversation

kitlaan
Copy link
Contributor

@kitlaan kitlaan commented Apr 28, 2023

Repro case

probably not the smallest repro, but it's what I got...

  1. create 3 windows, so you have 3 columns.
    It ends up looking like:
*--> WORKSPACE#1 @ws1
|   *--> MONITOR#0
|   |   *--> CON#0
|   |   |   *--> WINDOW#0
|   |   *--> CON#1
|   |   |   *--> WINDOW#0
|   |   *--> WINDOW#2
  1. apply focus on "the leftmost window"

  2. open up a window that is "already focused" (e.g. Zoom)

*--> WORKSPACE#1 @ws1
|   *--> MONITOR#0
|   |   *--> CON#0
|   |   |   *--> WINDOW#0 ... rect:...
|   |   |   *--> WINDOW#1
|   |   *--> CON#1
|   |   |   *--> WINDOW#0
|   |   *--> WINDOW#2
  1. adjust the width of the zoom window.

In my tests, CON#0 would adjust in width. Sometimes it'd push the rightmost window off the right side of the screen.

This patch neuters all the forge resize logic for floating windows? I think?

window.js Outdated Show resolved Hide resolved
@jmmaranan jmmaranan merged commit 4b93dcd into forge-ext:main Apr 29, 2023
@kitlaan kitlaan deleted the float-resize branch April 30, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants