New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Horrible implementation of stack variation and more #735

Open

0x3C50 opened this issue Oct 4, 2022 · 1 comment

0x3C50 commented Oct 4, 2022

jmockit1/main/src/mockit/asm/jvmConstants/JVMInstruction.java

Lines 15 to 19 in 5c6a2df

    
           String s = 
        
              "EFFFFFFFFGGFFFGGFFFEEFGFGFEEEEEEEEEEEEEEEEEEEEDEDEDDDDD" + 
        
              "CDCDEEEEEEEEEEEEEEEEEEEEBABABBBBDCFFFGGGEDCDCDCDCDCDCDCDCD" + 
        
              "CDCEEEEDDDDDDDCDCDCEFEFDDEEFFDEDEEEBDDBBDDDDDDCCCCCCCCEFED" + 
        
              "DDCDCDEEEEEEEEEEFEEEEEEDDEEDDEE";

This might save some space when writing, but the readability is horrible. "How much stack does this specific instruction modify?"

A better way to do it would be to make an enum with all relevant instructions, store them by index, and put the info in their params.

Col-E commented Oct 6, 2022

JMockit's asm package is based on an old release of Objectweb's ASM version 5. This existed upstream in ASM at the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment