Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch media list files to JSON #1594

Open
cycomachead opened this issue Jan 1, 2017 · 5 comments
Open

Switch media list files to JSON #1594

cycomachead opened this issue Jan 1, 2017 · 5 comments
Assignees
Labels
git / infra / code tooling, code organization, GitHub, etc

Comments

@cycomachead
Copy link
Collaborator

While JSON has a little more syntax the current file format, it would be quicker to parse (native parser) and we wouldn't have to worry about any edge cases that come up if we want to have descriptions that contain newlines and other things.

@cycomachead cycomachead added the git / infra / code tooling, code organization, GitHub, etc label Jan 1, 2017
@cycomachead cycomachead self-assigned this Jan 1, 2017
@PullJosh
Copy link

PullJosh commented Jan 2, 2017

JSON is also easier to read, for what it's worth.

@jmoenig
Copy link
Owner

jmoenig commented Jan 2, 2017

Can you tell me which problem this solves? Is there an issue with newlines in our XML format? If so, we should fix it, right?

@cycomachead
Copy link
Collaborator Author

I'm talking about the LIBRARIES / COSTUMES / SOUNDS etc files. The current files are a really loose new line and tab delimited format. It was better than scraping and parsing the HTML response pages, but there's definitely been a couple cases where a line doesn't correctly contain a tab character, and now BH gave me verbose descriptions for the new libraries, and those could be more nicely formatted.

(Of course, I could (in theory) adapt the 'parser' for the current format to handle more newlines or escapes, but it seems simpler and less error prone to use JSON.)

@jmoenig
Copy link
Owner

jmoenig commented Jan 2, 2017

Ah, now I see. Thanks!

@BookOwl
Copy link

BookOwl commented Jan 16, 2017

I created a PR for this in #1621

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
git / infra / code tooling, code organization, GitHub, etc
Projects
None yet
Development

No branches or pull requests

4 participants