New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python 3 support, Travis CI & a few modernisations #51
Conversation
Those were often randomly breaking a test or another.
…cmen & file-based caches.
I fixed the tests that were broken for Django 1.3 & 1.4 after merging. Travis CI passes with the following (see the results):
Coverage is 89% (see the results). Django 1.6 is still failing. 2 tests are failing with SQLite and 6 with PostgreSQL. I still don't understand why. |
Are you running the 1.6 tests in Travis somewhere as well? Also, superb work on this, it must have been a ton of effort. |
@jmoiron No, didn't try on Travis, only locally with Python 2.7, Django 1.4, 1.6, SQLite & PostgreSQL. |
@BertrandBordage how's the progress on this? What can I do to help with the Django 1.6 compatibility? I'm trying to figure out the best way for me to contribute to this pull request, and I think I may fork the main repo, then create a branch that tracks this branch of yours. |
@jmoiron @BertrandBordage I've got johnny-cache passing all the tests with Django 1.6 in my branch. I've got a pull request on @BertrandBordage's repo here. Let me know if I should open up a new pull request here, or you can pull / merge directly from my branch. |
@hxu I'm about ready to just tag master and pull this and your changes in to at least get some movement on supporting newer versions of django and clearing up some older bugs. Travis integration in particular is desirable since it's very time consuming to set up the johnny test environment. |
Python 3 support, Travis CI & a few modernisations
All of this and @hxu's additions are now in master and the previous master is tagged as |
In order to achieve johnny-cache 1.5 goals, I made the following:
failUnless
etc toassertTrue
,assertFalse
,assertEqual
andassertNotEqual
, all supported from Python 2.6