CSRF Exemption Removed #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 28, 2017 22:40
I’ve tested all the way down, and basically, because ofpython 3 compatibility, and other reasons, Django 1.7 is the mimimum we support (Also see note this isnt supported by Django community: > 1.8[46] 1 Apr 2015 Native support for multiple template engines. Long-term support release, supported until at least April 2018
Now has test covering this situation (?)
# Conflicts: # ramlwrap/utils/validation.py # tests/RamlWrapTest/tests/test_ramlwrap.py
Closed
|
Ooh now that's interesting, because I ran all the tox tests before committing and pushing (screen grab from local tox:
I will have to look at this later. |
|
I gave tox a run locally and get fails for py27-django7 and py3-django7... same as the travis. Not sure how your local ran fine.
|
|
Ok, if I force tox to reload its cache ( |
|
Dave has graciously found the cause - there is a django change (the builds worked fine for him on his mac) so I'm going to reverse-merge again, and re-run the tests. |
|
Closing as not part of RC2 structure: this code has been completly re-written. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has a new set of tests specifically to look at issue #14, but even with the
@csrf_exemptdecorator removed, I can't find any issues.I don't think this is needed for a release right now, but I would like to merge it in ready for whatever feature comes next.