-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kanban Board Review #1
Comments
Hi Team, While you made a great effort in this project, unfortunately, I cannot proceed to review your board. Invalid Code Review RequestYou have submitted a project, that does not contain a screenshot of the current state of the Kanban Board at the time of review request which is seen as a requirement here Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏 Cheers and Happy coding!👏👏👏 Feel free to leave any questions or comments in the Issue thread if something is not 100% clear. Please, do not open a new Issue for re-reviews. You should use the same Issue submitted for the first review, either valid or invalid unless it is requested otherwise. |
Thank you for reminding us about the screenshot @mcrd25! 🔧 |
Hi @jmonto55 Good job so far! To highlight:
Required Changes ♻️
Optional suggestionsEvery comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Cheers and Happy coding!👏👏👏 Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise. As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form. |
Hi team, Wow, you did it 🎉Thank you for implementing the changes requested by the previous reviewer 💪 🥇 ㊗️Well done!Congratulations! 🎉 To highlight
Optional suggestionsEvery comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application. Cheers and Happy coding!👏👏👏 Feel free to leave any questions or comments in the PR thread if something is not 100% clear. As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form. |
Links to the repositories:
Team Members: 4
Kanban Board Status
The text was updated successfully, but these errors were encountered: