Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kanban Board Review #1

Open
jmonto55 opened this issue Jun 7, 2023 · 4 comments
Open

Kanban Board Review #1

jmonto55 opened this issue Jun 7, 2023 · 4 comments

Comments

@jmonto55
Copy link
Owner

jmonto55 commented Jun 7, 2023

Links to the repositories:

Team Members: 4

Kanban Board Status

kanban_1

@mcrd25
Copy link

mcrd25 commented Jun 7, 2023

Hi Team,

While you made a great effort in this project, unfortunately, I cannot proceed to review your board.

Invalid Code Review Request

You have submitted a project, that does not contain a screenshot of the current state of the Kanban Board at the time of review request which is seen as a requirement here

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the Issue thread if something is not 100% clear.

Please, do not open a new Issue for re-reviews. You should use the same Issue submitted for the first review, either valid or invalid unless it is requested otherwise.

@jmonto55
Copy link
Owner Author

jmonto55 commented Jun 7, 2023

Thank you for reminding us about the screenshot @mcrd25! 🔧

@Meltrust
Copy link

Meltrust commented Jun 7, 2023

Hi @jmonto55

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

To highlight:

  • All tasks have been assigned✔️

You can do it

Required Changes ♻️

  • Some tasks do not have descriptions. Kindly ensure all of them have descriptions.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@Meltrust
Copy link

Meltrust commented Jun 7, 2023

Hi team,

Wow, you did it 🎉

Brilliant

Thank you for implementing the changes requested by the previous reviewer 💪 🥇 ㊗️

Well done!

Congratulations! 🎉

To highlight

  • All tasks have descriptions now✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants