Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problem getting back from a favorite to super favorites addon #3

Open
tstrul1 opened this issue Jun 22, 2021 · 10 comments
Open

problem getting back from a favorite to super favorites addon #3

tstrul1 opened this issue Jun 22, 2021 · 10 comments

Comments

@tstrul1
Copy link

tstrul1 commented Jun 22, 2021

Hi,
Hitting return while im in an addon that was opened from SF gets me to programs addon menu and main menu instead of getting back to SF main menu.

GIF for example:
https://ibb.co/0qVPWZN
log:
https://pastebin.com/raw/MA8GvgfY
debug log:
https://paste.ubuntu.com/p/xFxPkZP9fX/

kodi 19.1 on windows 10

Thanks in advance!

@jmooremcc
Copy link
Owner

I created a bug report back in January about a similar issue in Kodi Matrix and was told that Kodi's behavior is correct. My complaint had to do with the difference in how the back button worked vs the "..". I felt they should behave the same, meaning that pressing the back button should take you up one level in the virtual tree.

Personally, I've encountered the same problem you've reported when I created a folder in SF that represented a physical directory on my computer. Hitting the back button would not take me to the previous location but ".." would. I'm currently researching a solution but in the mean time you may have to work around the problem by clicking on ".." to move back to the previous location.

@tstrul1
Copy link
Author

tstrul1 commented Jun 28, 2021

Hey,
Im not sure its the exact same thing, even if i press .. im going back to program addons/video menu and not super favorites main menu.

@mrgsi
Copy link

mrgsi commented Apr 25, 2022

This problem has gotten much worse for me using the 2.2.6 update and Aeon-Nox Silvo skin. I get caught in an endless loop that doesn't stop until Kodi crashes on my PC. Hitting the back button or clicking on ".." takes me to the Kodi video menu then when I click the back button it takes me back into the add-on instead of SF menu. If I fall back to version 2.2.5 I can get out by hitting the back button a few times. Whatever was changed in the last update may hold the answer to completely fixing this issue. Even better if there was a way to avoid going to the previous menu and go directly to my Kodi home screen.

@jmooremcc
Copy link
Owner

This problem has gotten much worse for me using the 2.2.6 update and Aeon-Nox Silvo skin. I get caught in an endless loop that doesn't stop until Kodi crashes on my PC. Hitting the back button or clicking on ".." takes me to the Kodi video menu then when I click the back button it takes me back into the add-on instead of SF menu. If I fall back to version 2.2.5 I can get out by hitting the back button a few times. Whatever was changed in the last update may hold the answer to completely fixing this issue. Even better if there was a way to avoid going to the previous menu and go directly to my Kodi home screen.

I need more information. Please provide a debug log (remember to go into SF settings and enable debugging) plus more detailed information on what specifically you were doing.

Version 2.2.5 had a number of issues which were fixed on my Windows 11 PC and also on my Raspberry Pi4 in version 2.2.6.

@mrgsi
Copy link

mrgsi commented Apr 27, 2022

Sorry for the late reply, I just found some time to look at this. I have a video here: https://mrgsi.com/superfavs.mp4 and I have attached my log file. From what I see, it looks like a conflict with the Aeon-Nox-Silvo skin. I'm just not sure if it's xml coding or the skinshortcuts module. The problem only happens in Silvo's widgets or menu. It doesn't happen if I go into the add-ons browser, then into the super favourites add-on. It's weird and as I mention, worse with the latest update.
kodi.log

@jmooremcc
Copy link
Owner

jmooremcc commented Apr 27, 2022

I really appreciated the video you provided because it made it clear what's going on.
Unfortunately, your log file doesn't contain the debug information I need.

You should put the following in your advancesettings.xml file:
<advancedsettings> <loglevel>1</loglevel> </advancedsettings>
Next go into SF settings and enable debugging.

When debugging is enabled, I should see an entry like this one:
2022-04-27 12:03:32.737 T:26184 DEBUG <general>: Super Favourites V2.2.6 : ------------------ Launch Parameters ------------------
followed by other information that will help me track down the problem.

I'd also be interested in seeing what happens when you click on your back button. That's an area I fixed to make it work just like clicking on the the parent directory.

@mrgsi
Copy link

mrgsi commented Apr 27, 2022

It's the same if I use the mouse or the back button. If flashes kind of fast but I had keystrokes turned on for the video capture. It flashes in the bottom left. I took about 6 or 7 times hammering the back button to finally break out of the loop. My entire build is on-line if you ever want to play with it. You'd just need to update the version to the current one. I had the debug turned on but didn't work until I made that advanced settings edit. Here is the new log:
kodi.log

@mrgsi
Copy link

mrgsi commented Jan 4, 2023

Just to update, I noticed the issue I was having actually went away when I updated to Kodi 20. Problem is finally resolved.

@jmooremcc
Copy link
Owner

Just to update, I noticed the issue I was having actually went away when I updated to Kodi 20. Problem is finally resolved.

Glad to hear this. I've always known that the problem was the result of changes to the underlying code which changed Kodi's behavior.

@KOPRajs
Copy link

KOPRajs commented Nov 2, 2023

This problem seems to be the same as I'm describing here:
jmooremcc/plugin.program.super.favourites#13

I'm also sometimes caught in an endless loop switching between windows until Kodi crashes. Unfortunately I'm already on Kodi 20.1 and I'm using the default skin. There seems to be a race condition. Possibly a slow ARM device is more affected than a PC.

Debug log is attached in the above issue report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants